Rawls attempts to fetch "rawls" workspaces from WSM in addition to "MC"

[ashanhol]

Ticket: https://broadworkbench.atlassian.net/browse/AJ-1750

Currently, Rawls only returns policies for Azure workspaces, and an empty list for GCP ("rawls") workspaces. This is because GCP workspaces usually don't have a corresponding entry in WSM. However, GCP workspaces with linked snapshots do, and we need to try and retrieve that to display policies in the UI.

This PR attempts to make the WSM fetch call for all workspaces, and returns a default entry if it doesn't exist. It's a similar method to what we're doing in the snapshot code here.

---

PR checklist

• Include the JIRA issue number in the PR description and title
• Make sure Swagger is updated if API changes
  • ...and Orchestration's Swagger too!
• If you changed anything in model/, then you should publish a new official rawls-model and update rawls-model in Orchestration's dependencies.
• Get two thumbsworth of PR review
• Verify all tests go green, including CI tests
• Squash commits and merge to develop (branches are automatically deleted after merging)
• Inform other teams of any substantial changes via Slack and/or email

[yuliadub]

do we need a test for this specific call or does that exist somewhere else already? (I'd assume so but wanted to check)

[ashanhol]

im still trying to figure that out

[ashanhol]

I think this is the right way to go about it. From what I saw, looks like I either have to create a workspace this way or call services.workspaceService.createWorkspace, otherwise calling both throws a "workspace' already exists" error.

[davidangb]

👍, with optional syntax suggestions - thank you!

[davidangb]

This code is correct and in good shape, and I would not block the PR on changes here. However, the use of try/catch is Java-idiomatic, where the use of Try/Success/Failure is Scala-idiomatic. To be a good Scala citizen, you'd have something like this:

Suggested change

	val wsmContext =
	try
	wsmService.fetchAggregatedWorkspace(workspaceContext, ctx)
	catch {
	case e: AggregateWorkspaceNotFoundException =>
	// return workspace with no WSM information for gcp workspace
	if (workspaceContext.workspaceType == WorkspaceType.RawlsWorkspace) {
	AggregatedWorkspace(workspaceContext,
	Some(workspaceContext.googleProjectId),
	azureCloudContext = None,
	policies = List.empty
	)
	} else {
	// bubble up an MC workspace exception
	throw e
	}
	}
	val wsmContext =
	Try(wsmService.fetchAggregatedWorkspace(workspaceContext, ctx)) match {
	case Success(found) => found
	case Failure(notFound: AggregateWorkspaceNotFoundException)
	if workspaceContext.workspaceType == WorkspaceType.RawlsWorkspace =>
	// return workspace with no WSM information for gcp workspace
	AggregatedWorkspace(workspaceContext,
	Some(workspaceContext.googleProjectId),
	azureCloudContext = None,
	policies = List.empty
	)
	case Failure(x) => throw x // bubble up an MC workspace exception
	}

[davidangb]

I also won't block the PR on any changes here; this code is fine. You could streamline a lot of the assertions by defining the expected result and checking for that, though:

Suggested change

	val response = readWorkspace.convertTo[WorkspaceResponse]
	response.workspace.name shouldBe workspaceName
	response.azureContext shouldEqual None
	response.workspace.cloudPlatform shouldBe Some(WorkspaceCloudPlatform.Gcp)
	response.policies should not be empty
	val policies: List[WorkspacePolicy] = response.policies.get
	policies should not be empty
	val policy: WorkspacePolicy = policies.head
	policy.name shouldBe wsmPolicyInput.getName
	policy.namespace shouldBe wsmPolicyInput.getNamespace
	val additionalData = policy.additionalData
	additionalData.length shouldEqual 2
	additionalData.head.getOrElse("pair1Key", "fail") shouldEqual "pair1Val"
	additionalData.tail.head.getOrElse("pair2Key", "fail") shouldEqual "pair2Val"
	val response = readWorkspace.convertTo[WorkspaceResponse]
	response.workspace.name shouldBe workspaceName
	response.azureContext shouldEqual None
	response.workspace.cloudPlatform shouldBe Some(WorkspaceCloudPlatform.Gcp)
	val expectedPolicy: WorkspacePolicy = new WorkspacePolicy("test_name",
	"test_namespace",
	List(
	Map("pair1Key" -> "pair1Val"),
	Map("pair2Key" -> "pair2Val")
	)
	)
	response.policies should contain(List(expectedPolicy))