Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA-2282: Add app-version output #2832

Merged
merged 4 commits into from
Apr 17, 2024
Merged

QA-2282: Add app-version output #2832

merged 4 commits into from
Apr 17, 2024

Conversation

ichengchang
Copy link
Contributor

@ichengchang ichengchang commented Apr 16, 2024

Ticket: QA-2282

Use the following logic to determine app versioning for contract tests
If the current commit hash for tag is the same as the current commit hash,

  • app version of published contract = tag from bumper output, otherwise
  • app version of published contract = new_tag from bumper output

PR checklist

  • Include the JIRA issue number in the PR description and title
  • Make sure Swagger is updated if API changes
    • ...and Orchestration's Swagger too!
  • If you changed anything in model/, then you should publish a new official rawls-model and update rawls-model in Orchestration's dependencies.
  • Get two thumbsworth of PR review
  • Verify all tests go green, including CI tests
  • Squash commits and merge to develop (branches are automatically deleted after merging)
  • Inform other teams of any substantial changes via Slack and/or email

@calypsomatic
Copy link
Contributor

Use the following logic to determine app versioning for contract tests If the current commit hash for tag is the same as the current commit hash,

This check happens in the bumper workflow?

Copy link
Contributor

@jyang-broad jyang-broad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! now compares tag + new-tag into app-version which is the "correct" version of pact contracts to test.

.github/workflows/tag.yml Show resolved Hide resolved
@ichengchang
Copy link
Contributor Author

Use the following logic to determine app versioning for contract tests If the current commit hash for tag is the same as the current commit hash,

This check happens in the bumper workflow?

Yes this check happens in the bumper workflow, as shown below

https://github.com/DataBiosphere/github-actions/blob/master/actions/bumper/entrypoint.sh#L76-L88

# get current commit hash for tag
# on the initial use, this shows usage, because $tag is empty. The logic below still works.
tag_commit=$(git rev-list -n 1 $tag)

# get current commit hash
commit=$(git rev-parse HEAD)

if [ "$tag_commit" == "$commit" ]; then
    echo "No new commits since previous tag. Skipping..."
    echo tag=$tag >> $GITHUB_OUTPUT
    exit 0
fi

@ichengchang ichengchang merged commit d2eb21d into develop Apr 17, 2024
25 of 26 checks passed
@ichengchang ichengchang deleted the QA-2282 branch April 17, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants