RW-12554 Send metrics when we run into Cannot delete a resource with children
#2882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qi77Qi
force-pushed
the
qiretry400
branch
2 times, most recently
from
b90629e to
a068af2
Compare
Qi77Qi
commented
May 20, 2024
| IO(fastPassFailureCounter.add(1, Attributes.of(AttributeKey.stringKey("function"), functionName))) | ||
| } | ||
| def incrementFastPassFailureCounter(functionName: String): IO[Unit] = | ||
| IO(fastPassFailureCounter.add(1, Attributes.of(AttributeKey.stringKey("function"), functionName))) |
There was a problem hiding this comment.
these are from scalafmtAll
Qi77Qi
commented
May 20, 2024
| AttributeKey.stringKey("member_type"), memberType.toString, | ||
| AttributeKey.stringKey("action"), action | ||
| ))) | ||
| def incrementCounter(name: String, |
There was a problem hiding this comment.
this is the only method I added
| @@ -209,6 +209,7 @@ case class Workspace( | |||
| def toWorkspaceName: WorkspaceName = WorkspaceName(namespace, name) | |||
| def briefName: String = toWorkspaceName.toString | |||
| def path: String = toWorkspaceName.path | |||
| def isAoU: Boolean = googleProjectId.value.startsWith("terra-vpc-sc-") | |||
There was a problem hiding this comment.
I wonder if there's a more generic counter we can expose here rather than a boolean isAou. That is, we may have other consumers we want to slice on in the future that use service perimeter's etc. Perhaps a project type "base" or "vpc"?
aherbst-broad
approved these changes
May 21, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://precisionmedicineinitiative.atlassian.net/browse/RW-12554
PR checklist
model/, then you should publish a new officialrawls-modeland updaterawls-modelin Orchestration's dependencies.