[CORE-368] Validate entitytype rename

[calypsomatic]

Ticket: https://broadworkbench.atlassian.net/browse/CORE-368

Adds in name validation when renaming an entity. DataBiosphere/terra-ui#5272 also does this from the front end.

---

PR checklist

• Include the JIRA issue number in the PR description and title
• Make sure Swagger is updated if API changes
  • ...and Orchestration's Swagger too!
• If you changed anything in model/, then you should publish a new official rawls-model and perform the corresponding dependency updates as specified in the README:
  • in the automation subdirectory
  • in workbench-libs
  • in firecloud-orchestration
• Get two thumbsworth of PR review
• Verify all tests go green, including CI tests
• Squash commits and merge to develop (branches are automatically deleted after merging)
• Inform other teams of any substantial changes via Slack and/or email

[davidangb]

validateEntityName checks syntax for an entity name, not an entity type. See

rawls/core/src/main/scala/org/broadinstitute/dsde/rawls/dataaccess/slick/EntityComponent.scala

Lines 1408 to 1423 in 4143698

	private def validateEntity(entity: Entity): Unit = {
	if (entity.entityType.equalsIgnoreCase(Attributable.workspaceEntityType)) {
	throw new RawlsFatalExceptionWithErrorReport(
	errorReport = ErrorReport(
	message = s"Entity type ${Attributable.workspaceEntityType} is reserved and cannot be overwritten",
	statusCode = StatusCodes.BadRequest
	)
	)
	}
	validateUserDefinedString(entity.entityType)
	validateEntityName(entity.name)
	entity.attributes.keys.foreach { attrName =>
	validateUserDefinedString(attrName.name)
	validateAttributeName(attrName, entity.entityType)
	}
	}

for the logic around validating entity types. You might wanna break out the two validations inside EntityComponent.validateEntity that look at entityType into a new method, then call that new method from here

[calypsomatic]

Ah dang I looked very carefully at the different methods and still picked the wrong one 😵