CORE-81: strip info from error messages before responding #3213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidangb
commented
Mar 5, 2025
| @@ -34,7 +34,7 @@ trait HttpClientUtils extends LazyLogging { | |||
| executeRequest(http, httpRequest) recover { case t: Throwable => | |||
| throw new RawlsExceptionWithErrorReport( | |||
| ErrorReport(StatusCodes.InternalServerError, | |||
| s"HTTP call failed: ${httpRequest.uri}. Response: ${t.getMessage}", | |||
| s"HTTP call failed: ${filterPrivate(httpRequest.uri)}. Response: ${t.getMessage}", | |||
There was a problem hiding this comment.
It felt helpful to include the target uri in the error message, as long as that uri was not private; so I added a filter instead of removing the uri altogether
davidangb
changed the title
davidangb
requested review from
calypsomatic and
samanehsan
and removed request for
a team
calypsomatic
approved these changes
Mar 6, 2025
samanehsan
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: CORE-81
Two changes in this PR to address info disclosure in error messages:
Both of these fixes should cover many more cases than the three mentioned in the Jira ticket, though this PR is certainly not a comprehensive audit of info disclosure in error messages.
PR checklist
model/, then you should publish a new officialrawls-modeland perform the corresponding dependency updates as specified in the README: