Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lk dynamically select barcode orientation #1086

Merged
merged 26 commits into from
Sep 23, 2023

Conversation

ekiernan
Copy link
Contributor

Description

This PR adds a simple python script to teh ATAC FASTQ Process WDL to check barcode orientation on 1000 barcodes randomly selected from the first ATAC fastq read2 file.


Checklist

If you can answer "yes" to the following items, please add a checkmark next to the appropriate checklist item(s) and notify our WARP documentation team by tagging either @ekiernan or @kayleemathews in a comment on this PR.

  • Did you add inputs, outputs, or tasks to a workflow?
  • Did you modify, delete or move: file paths, file names, input names, output names, or task names?
  • If you made a changelog update, did you update the pipeline version number?

@github-actions
Copy link

Remember to squash merge!

@github-actions
Copy link

Remember to squash merge!

@github-actions
Copy link

Remember to squash merge!

@github-actions
Copy link

Remember to squash merge!

@github-actions
Copy link

Remember to squash merge!

@github-actions
Copy link

Remember to squash merge!

Copy link
Contributor

@kevinpalis kevinpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@aawdeh aawdeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link

Remember to squash merge!

@github-actions
Copy link

Remember to squash merge!

@github-actions
Copy link

Remember to squash merge!

@github-actions
Copy link

Remember to squash merge!

@ekiernan ekiernan merged commit b7461f1 into develop Sep 23, 2023
3 checks passed
@ekiernan ekiernan deleted the lk-dynamically-select-barcode-orientation branch September 23, 2023 00:39
@ekiernan ekiernan restored the lk-dynamically-select-barcode-orientation branch September 23, 2023 00:39
khajoue2 added a commit that referenced this pull request Nov 2, 2023
* Update Loom_schema.md (#1080)

* Lk dynamically select barcode orientation (#1086)

* Added dynamic barcode selection to the ATAC FastqProcess task

* Np pd 2327 separate unmapped reads (#1084)

* add separate unmapped reads task

* clean up

* add splut unmapped reads (#1087)

* KM Update metrics descriptions (#1088)

* Update metrics descriptions

* Update Loom_schema.md

* Update Loom_schema.md

* Add TagSort and definitions

* Km fix broken links in docs (#1090)

* Update Terra link address

* Fix links to snaptools Docker

* Fixed link to SS2 overview

* Update link to snM3C test_inputs directory

* Fixed link to Multiome test data

* Fix link to loom_to_h5ad.py script

* Fix link to loom creation script

* Fixed links

* Lk pd 2363 join barcodes (#1089)

Added GEX and ATAC whitelist barcodes to both ATAC and GEX h5ad files so that barcodes that can be joined.

* Update UnmappedBamToAlignedBam.wdl (#1070)

Changed MarkDuplicates task to use Float size(Array[File], [String])

* Np add single end r1 r2 mapping dna mode and merge sort split reads by name (#1092)

* echo whitelistnew task

* rearranging

* cleaning up

* cleaning up

* cleaning up

* formatting

---------

Co-authored-by: aawdeh <[email protected]>

* Lk pd 2374 update whitelist (#1093)

Updated path of multiome whitelists

* Km fix broken links in WARP docs (#1097)

* Update Multiome README

* Update broken links in docs

* Update get-started.md

* Update broken bookmarks in docs

* Remove the dropna and MATCH columns from JoinBarcodes (#1098)

* Remove the dropna and MATCH columns from JoinBarcodes

* PD-2379-add_remove_overlap_read_parts_task (#1094)

* Added merge_original_and_split_bam_sort_all_reads_name_and_position

* Cleaning up a few ls and pwds, adding echos

* add task dedup_unique_bam_and_index_unique_bam (#1103)

* Km atac h5ad overview (#1102)

* Create count-matrix-overview.md

* Update count-matrix-overview.md

* Add barcode column names

Add the column names containing the GEX and ATAC barcodes in the output h5ad files to the Multiome README

* Update count-matrix-overview.md

* Update README.md

* Km doc updates (#1100)

* Update links in Optimus Overview doc

* Update version numbers in READMEs

* Update count-matrix-overview.md

* Update count-matrix-overview.md

* Add link to SnapATAC2 import_data function

* Update count-matrix-overview.md

* Update website/docs/Pipelines/ATAC/count-matrix-overview.md

Co-authored-by: ekiernan <[email protected]>

* Update website/docs/Pipelines/ATAC/count-matrix-overview.md

Co-authored-by: ekiernan <[email protected]>

* Update website/docs/Pipelines/ATAC/count-matrix-overview.md

Co-authored-by: ekiernan <[email protected]>

---------

Co-authored-by: ekiernan <[email protected]>

* Add unique_reads_allc

* Update CondensedSnm3C.wdl

* Km add atac rrid and update multiome readme (#1109)

* Update Multiome README

* Update pipeline version output

* Update README.md

* Update inputs to CramToUnmappedBam test (#1104)

* update paths to input files

* Add unique_reads_cgn_extraction task (#1107)

---------

Co-authored-by: ekiernan <[email protected]>
Co-authored-by: Nikelle Petrillo <[email protected]>
Co-authored-by: Kaylee Mathews <[email protected]>
Co-authored-by: aawdeh <[email protected]>
Co-authored-by: ekiernan <[email protected]>
Co-authored-by: Jessica Way <[email protected]>
@ekiernan ekiernan deleted the lk-dynamically-select-barcode-orientation branch December 20, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants