Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding gex barcodes to the multiome fragment file #1133

Merged
merged 24 commits into from
Dec 6, 2023
Merged

adding gex barcodes to the multiome fragment file #1133

merged 24 commits into from
Dec 6, 2023

Conversation

ekiernan
Copy link
Contributor

Description

Added gene expression barcodes to the final Multiome ATAC fragment file as last column in TSV

Checklist

If you can answer "yes" to the following items, please add a checkmark next to the appropriate checklist item(s) and notify our WARP documentation team by tagging either @ekiernan or @kayleemathews in a comment on this PR.

  • Did you add inputs, outputs, or tasks to a workflow?
  • Did you modify, delete or move: file paths, file names, input names, output names, or task names?
  • If you made a changelog update, did you update the pipeline version number?

@github-actions GitHub Actions
Copy link

Remember to squash merge!

@github-actions GitHub Actions
Copy link

Remember to squash merge!

@github-actions GitHub Actions
Copy link

Remember to squash merge!

@github-actions GitHub Actions
Copy link

Remember to squash merge!

@github-actions GitHub Actions
Copy link

Remember to squash merge!

@github-actions GitHub Actions
Copy link

Remember to squash merge!

@github-actions GitHub Actions
Copy link

Remember to squash merge!

@github-actions GitHub Actions
Copy link

Remember to squash merge!

@github-actions GitHub Actions
Copy link

Remember to squash merge!

@github-actions GitHub Actions
Copy link

Remember to squash merge!

@ekiernan
Copy link
Contributor Author

To test the new fragment file against the plumbing truth, I moved all files to the VM. For the new bgzipped file, I ran bgzip -d file. I then 1) removed the last column (GEX barcodes) of the test file and sorted the truth file. I ran md5sum and got the same result. Screenshot is in ticket.

@github-actions GitHub Actions
Copy link

Remember to squash merge!

@github-actions GitHub Actions
Copy link

Remember to squash merge!

jessicaway
jessicaway approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@jessicaway jessicaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

kayleemathews
kayleemathews reviewed Dec 4, 2023
View reviewed changes
Copy link
Contributor

@kayleemathews kayleemathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor doc things that should get updated but otherwise LGTM!

pipelines/skylab/multiome/Multiome.changelog.md Show resolved Hide resolved
website/docs/Pipelines/Multiome_Pipeline/README.md Outdated Show resolved Hide resolved
website/docs/Pipelines/Multiome_Pipeline/README.md Outdated Show resolved Hide resolved
website/docs/Pipelines/ATAC/README.md Outdated Show resolved Hide resolved
pipelines/skylab/optimus/Optimus.changelog.md Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023

Remember to squash merge!

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023

Remember to squash merge!

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023

Remember to squash merge!

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023

Remember to squash merge!

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023

Remember to squash merge!

kayleemathews
kayleemathews approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@kayleemathews kayleemathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to me! Thanks for making those changes @ekiernan!

kevinpalis
kevinpalis approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@kevinpalis kevinpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023

Remember to squash merge!

@ekiernan ekiernan added the eng-only Scientific review not needed label Dec 5, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023

Remember to squash merge!

@ekiernan ekiernan merged commit 409c8be into develop Dec 6, 2023
3 checks passed
@ekiernan ekiernan deleted the lk-PD2432-gex-barcodes-to-fragment-file branch December 6, 2023 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kayleemathews kayleemathews kayleemathews approved these changes

@jessicaway jessicaway jessicaway approved these changes

@kevinpalis kevinpalis kevinpalis approved these changes

@gbggrant gbggrant Awaiting requested review from gbggrant

@kachulis kachulis Awaiting requested review from kachulis

@samuelklee samuelklee Awaiting requested review from samuelklee

Assignees
No one assigned
Labels
eng-only Scientific review not needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ekiernan @kevinpalis @jessicaway @kayleemathews