adding new verification test #1387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Remember to squash merge! |
🔍Version Validation Results: |
🔍Changelog Validation Results: |
|
Testing Optimus scientific here: https://gotc-jenkins.dsp-techops.broadinstitute.org/job/warp-workflow-tests/85996/ |
|
Remember to squash merge! |
🔍Changelog Validation Results: |
🔍Version Validation Results: |
|
retest this please |
|
Remember to squash merge! |
🔍Changelog Validation Results: |
🔍Version Validation Results: |
|
Remember to squash merge! |
🔍Changelog Validation Results: |
🔍Version Validation Results: |
|
Remember to squash merge! |
🔍Changelog Validation Results: |
🔍Version Validation Results: |
nikellepetrillo
approved these changes
Oct 21, 2024
jessicaway
approved these changes
Oct 21, 2024
verification/VerifyTasks.wdl
Outdated
| truth_files_length=~{length(truth_text_files)} | ||
| if [ $test_files_length -ne $truth_files_length ]; then | ||
| exit_code=1 | ||
| echo "Error: Different number of input files ($test_files_length vs. $truth_files_length). This is really not OK" |
There was a problem hiding this comment.
Should we exit? No need to look further, right?
|
Remember to squash merge! |
🔍Version Validation Results: |
🔍Changelog Validation Results: |
|
Remember to squash merge! |
|
Remember to squash merge! |
🔍Version Validation Results: |
🔍Changelog Validation Results: |
|
Remember to squash merge! |
🔍Changelog Validation Results: |
🔍Version Validation Results: |
|
Remember to squash merge! |
🔍Changelog Validation Results: |
🔍Version Validation Results: |
…m/broadinstitute/warp into lk-pd-2778-optimus-library-verify
|
Remember to squash merge! |
🔍Changelog Validation Results: |
🔍Version Validation Results: |
jessicaway
approved these changes
Oct 23, 2024
| echo "$diff_output" | ||
| exit_code=2 | ||
| fi | ||
| fi |
There was a problem hiding this comment.
Thank you! I reformatted.
verification/VerifyTasks.wdl
Outdated
|
|
||
| if [ $md5_a = $md5_b ]; then | ||
| echo "Files $a.sorted and $b.sorted have matching md5sums and are the same." | ||
| else |
There was a problem hiding this comment.
Being super nit picky, but I think the indentation is a bit off (sometimes using 4 spaces and sometimes 2 spaces)
nikellepetrillo
approved these changes
Oct 23, 2024
|
Remember to squash merge! |
🔍Changelog Validation Results: |
🔍Version Validation Results: |
|
Remember to squash merge! |
🔍Changelog Validation Results: |
🔍Version Validation Results: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new verification task to compare Optimus library metric CSV files. If the md5sums fail, it performs additional checks on the lines that are not related to doublet score.