Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lk pd 2786 add atac expectedcells #1398

Merged
merged 22 commits into from
Oct 30, 2024
Merged

Conversation

ekiernan
Copy link
Contributor

This PR does the following:

  1. Modifies the existing Optimus input expected_cells to be required and to be renamed gex_expected_cells
  2. Adds a new ATAC input of atac_expected_cells
  3. Reformats the ATAC library CSV to be consistent with the case of the gene expression library CSV produced by Optimus
  4. Renamed ATAC and gene expression library CSV filenames to remove an extra atac and gex descriptor, respectively
  5. Add a new metric of percent_target to the ATAC library CSV, which is the estimated_cells divided by the expected_cells

Copy link

Remember to squash merge!

Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
MultiSampleSmartSeq2SingleNucleus.wdl has not been changed and needs updating
SlideSeq.wdl has not been changed and needs updating
Some WDLs or changelog files need updating. See output for details.
validation_failed

Copy link

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
MultiSampleSmartSeq2SingleNucleus.changelog.md has not been changed and needs to be updated
SlideSeq.changelog.md has not been changed and needs to be updated
Some changelog files need updating. See output for details.
validation_failed

@ekiernan ekiernan closed this Oct 23, 2024
@ekiernan ekiernan reopened this Oct 23, 2024
Copy link

Remember to squash merge!

1 similar comment
Copy link

Remember to squash merge!

Copy link

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.

Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

Copy link

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.

Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

Copy link

Remember to squash merge!

Copy link

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.

Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

@ekiernan
Copy link
Contributor Author

All smart-test failures make sense given the changes; complete log of failures here: https://docs.google.com/spreadsheets/d/1g1IGaEWwXz-xl0T-YxZAk5dnvJyQa1kQx71gFulcLUA/edit?gid=326568500#gid=326568500

Copy link
Contributor

@nikellepetrillo nikellepetrillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

Copy link
Contributor

@aawdeh aawdeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

Remember to squash merge!

Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

Copy link

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.

Copy link

Remember to squash merge!

Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

Copy link

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.

@ekiernan ekiernan merged commit 1cd67fe into develop Oct 30, 2024
13 checks passed
@ekiernan ekiernan deleted the lk-PD-2786-Add-ATAC-Expectedcells branch October 30, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants