Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging -> master #1414

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Staging -> master #1414

merged 3 commits into from
Nov 8, 2024

Conversation

nikellepetrillo
Copy link
Contributor

Description

Give your PR a concise yet descriptive title.
Please explain the changes you made here.
Explain the motivation for making this change. What existing problem does the pull request solve?
Mention any issues fixed, addressed, or otherwise related to this pull request, including issue numbers or hard links for issues in other repos.
You can delete these instructions once you have written your PR description.


Checklist

If you can answer "yes" to the following items, please add a checkmark next to the appropriate checklist item(s) and notify our WARP team by tagging @broadinstitute/warp-admins in a comment on this PR.

  • Did you add inputs, outputs, or tasks to a workflow?
  • Did you modify, delete or move: file paths, file names, input names, output names, or task names?
  • If you made a changelog update, did you update the pipeline version number?

nikellepetrillo and others added 3 commits November 5, 2024 17:13
* gatk docker update

* gatk docker update

* revert bqsr to gstk 4.3

* revert genotypeconcordance to gstk 4.3

* revert genotypeconcordance to gstk 4.3

* add megans commit

* add megans commit

* fix names of inputs for CompareVCFsVerbosely

* fix names of inputs for CompareVCFsVerbosely

* hook up index files

* missed some test inputs

* changelogs and versions

* Updated pipeline_versions.txt with all pipeline version information

* changelogs

* Updated pipeline_versions.txt with all pipeline version information

* changelogs

* Updated pipeline_versions.txt with all pipeline version information

---------

Co-authored-by: GitHub Action <[email protected]>
* Fix: Use CSI instead of TBI indexing in tabix command to support chromosomes larger than 512 Mbp.

* Updated pipeline_versions.txt with all pipeline version information

* Updated pipeline_versions.txt with all pipeline version information

* updated changelogs

* Updated pipeline_versions.txt with all pipeline version information

* updated pairedtag version

* Updated pipeline_versions.txt with all pipeline version information

* CreateFragmentFile task now uses csi index format

* Update pipelines/skylab/multiome/Multiome.changelog.md

Co-authored-by: Elizabeth Kiernan <[email protected]>

* Update pipelines/skylab/optimus/Optimus.changelog.md

Co-authored-by: Elizabeth Kiernan <[email protected]>

* Update pipelines/skylab/slideseq/SlideSeq.changelog.md

Co-authored-by: Elizabeth Kiernan <[email protected]>

* Update pipelines/skylab/smartseq2_single_nucleus_multisample/MultiSampleSmartSeq2SingleNucleus.changelog.md

Co-authored-by: Elizabeth Kiernan <[email protected]>

* Update pipelines/skylab/paired_tag/PairedTag.changelog.md

Co-authored-by: Elizabeth Kiernan <[email protected]>

* Updated pipeline_versions.txt with all pipeline version information

* updating indexing for pairedtag and changing index file name

* Updated outputs to reflect the csi index. Renamed the index from tbi to index

* Update Multiome.wdl

changed JoinBarcodes task index file name

* Update pipelines/skylab/atac/atac.wdl

Co-authored-by: Elizabeth Kiernan <[email protected]>

---------

Co-authored-by: GitHub Action <[email protected]>
Co-authored-by: Elizabeth Kiernan <[email protected]>
Co-authored-by: ekiernan <[email protected]>
Copy link

github-actions bot commented Nov 6, 2024

DO NOT SQUASH MERGE!!!

Copy link

github-actions bot commented Nov 6, 2024

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/master':
All changelog files are valid for this release.

Copy link

github-actions bot commented Nov 6, 2024

🔍Version Validation Results:

basename: missing operand
Try 'basename --help' for more information.
Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

@nikellepetrillo
Copy link
Contributor Author

nikellepetrillo commented Nov 7, 2024

Multiome, optimus, and paired tag are failing due to nondetermism affecting the doublet_score metric:

Multiome

Cell Metric Column does not match:
doublet_score
Sum of test: 
1219.9300000000003
Sum of truth: 
1256.1800000000003

Optimus

8kpbmc
Cell Metric Column does not match:
doublet_score
Sum of test: 
1190.332288401254
Sum of truth: 
1207.1969696969697

8k_pbmc_stranded
Cell Metric Column does not match:
doublet_score
Sum of test: 
1183.492685475444
Sum of truth: 
1219.707157784744

PairedTag

dev_BC011_10kPBMC 
Cell Metric Column does not match:
doublet_score
Sum of test: 
1218.1699999999996
Sum of truth: 
1241.64

dev_10k_pbmc
Cell Metric Column does not match:
doublet_score
Sum of test: 
1269.1000000000001
Sum of truth: 
1256.1800000000003

CheckFingerprint failed with a transient error. Rerunning here: https://gotc-jenkins.dsp-techops.broadinstitute.org/job/warp-workflow-tests/88299/console

UltimaGenomicsJointJenotyping is failing due to some slight wiggles but @meganshand has given us the ok to update the truth for this pipeline https://gotc-jenkins.dsp-techops.broadinstitute.org/job/warp-workflow-tests/88301/

@nikellepetrillo nikellepetrillo merged commit 599f119 into master Nov 8, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants