Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

staging --> master #1422

Merged
merged 6 commits into from
Nov 15, 2024
Merged

staging --> master #1422

merged 6 commits into from
Nov 15, 2024

Conversation

ekiernan
Copy link
Contributor

staging --> master

aawdeh and others added 6 commits November 7, 2024 10:14
@aawdeh
PD-2779: Add README file for CEMBA file path deprecation (#1412)
66a7e76 
* add readme

* add readme

* fix readme

* added whitelsit
@ekiernan
Update ComareH5adFilesGEX (#1416)
52a7ff6 
Updated comparisons for GEX h5ad files
@ekiernan
Lk atac percent target (#1419)
6fda53e 
Renamed ATAC percent_target to atac_percent_target
@nikellepetrillo
Np nondeterminism atac lib metrics (#1409)
211ec9b 
* testing

* testing

* python

* syntax

* syntax

* syntax

* remove write lines

* remove write lines

* remove write lines

* sep

* indent

* more indents

* double quotes

* return error

* threshold change

* hook up atac lib metrics for paired tag

* fix thresholds

* check thresholds

* make volatile

* lowercase

* remove print

* fix lowrcases and print thresholds

* remove thresholds print statement

* remove thresholds print statement

* missing a parens

* quote
@ekiernan
adding memory for parsebarcodes and joinbarcodes (#1420)
cd948ed 
added more memory and disk to ParseBarcodes and JoinBarcodes
@ekiernan
Merge pull request #1421 from broadinstitute/develop
7788894 
dev --> staging
@github-actions GitHub Actions
Copy link

DO NOT SQUASH MERGE!!!

@github-actions GitHub Actions
Copy link

🔍Version Validation Results:

basename: missing operand
Try 'basename --help' for more information.
Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

@github-actions GitHub Actions
Copy link

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/master':
All changelog files are valid for this release.

@ekiernan
Copy link
Contributor Author

ekiernan commented Nov 14, 2024 •
edited
Loading

Multiome test is just expected error in atac_percent_target:
PairedTag is no library metric file exists in truth; will update the truth
Slideseq: the h5ad counts are off by 2. Will update truth.

Passing scientific tests:
Multiome: https://gotc-jenkins.dsp-techops.broadinstitute.org/job/warp-workflow-tests/88822/
PairedTag: https://gotc-jenkins.dsp-techops.broadinstitute.org/job/warp-workflow-tests/88823/
Slideseq: https://gotc-jenkins.dsp-techops.broadinstitute.org/job/warp-workflow-tests/88824/

@ekiernan ekiernan merged commit ef0a523 into master Nov 15, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessicaway jessicaway jessicaway approved these changes

@khajoue2 khajoue2 khajoue2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ekiernan @khajoue2 @jessicaway @aawdeh @nikellepetrillo