Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(.env): allow environment variables to be passed dynamically to a container #1699

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

omarsoufiane
Copy link

In a production environment, keeping the environment variables inside the docker image is not recommended.
In production, we will most likely use Kubernetes or a container service like ECS where environment variables are passed dynamically to the container from a configmap or a secrets store. with the current configuration the dynamically passed environment variables are overridden by the local .env file that was present during the build of the container.
when I removed the .env file from the docker file I noticed that TypeORM Cli wasn't working correctly because it uses "env-cmd" which requires a .env but isn't necessary in an environment where the variables are dynamic.
so I created a little script "typeorm-cli.js" that would run typeorm CLI with "env-cmd" when needed and without it in a production environment such as kubernetes or ECS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant