Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update indentation on ci_test_package.yml and Python 3.8 to 3.9 #471

Merged
merged 4 commits into from
Jan 10, 2025

Conversation

mtcarlone
Copy link
Contributor

Overview

Updates the indentation for single-run-different-versions step for sqlserver. The yml indentation put the runs-on and environment properties under strategy, when they should be inline with that property.

Update type - breaking / non-breaking

  • Minor bug fix
  • Documentation improvements
  • Quality of Life improvements
  • New features (non-breaking change)
  • New features (breaking change)
  • Other (non-breaking change)
  • Other (breaking change)
  • Release preparation

What does this solve?

Should solve CI issues once merged

Outstanding questions

What databases have you tested with?

  • Snowflake
  • Google BigQuery
  • Databricks
  • Spark
  • N/A

@mtcarlone mtcarlone had a problem deploying to Approve Integration Tests January 9, 2025 21:27 — with GitHub Actions Failure
@mtcarlone mtcarlone changed the title Update ci_test_package.yml Update indentation on ci_test_package.yml Jan 9, 2025
@mtcarlone mtcarlone temporarily deployed to Approve Integration Tests January 9, 2025 21:31 — with GitHub Actions Inactive
@mtcarlone mtcarlone requested a deployment to Approve Integration Tests January 9, 2025 21:40 — with GitHub Actions Waiting
@mtcarlone mtcarlone temporarily deployed to Approve Integration Tests January 9, 2025 21:44 — with GitHub Actions Inactive
@mtcarlone mtcarlone changed the title Update indentation on ci_test_package.yml Update indentation on ci_test_package.yml and Python 3.8 to 3.9 Jan 9, 2025
@mtcarlone mtcarlone merged commit 6a94c68 into main Jan 10, 2025
1 check passed
@mtcarlone mtcarlone deleted the bug/update-indentation-for-yml branch January 10, 2025 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants