Scoping issue in timezones/fields.py/prep_localized_datetime() #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I filed this before, but it may have got lost when github totally reworked their pull request subsystem. Anyway, it looks to me like the issue is still present in your latest code at time of writing.
You've got a scoping issue in prep_localized_datetime, just the way python scoping works. Without a fix, means you potentially get weird behaviour, particularly if you have multiple LocalizedDateTimeFields on the one model. Anyway, attached is one possible suggestion to fix the issue.
N.B. I'm leaving django-land very shortly (end of contract), found this going through some old tickets prior to leaving, so I personally may not be contactable regarding this issue after this thursday (31st March 2011) (bound to be someone at ichec.ie available, just not dgoldenichec...)