-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support django 1.7 migration #22
Open
anhtran
wants to merge
100
commits into
brosner:master
Choose a base branch
from
anhtran:develop
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can be run with 'django-admin.py test timezones'
Letting exceptions propogate without modification.
It's identical to the modelform default. You can get the same formfield from timezone_field.fields.TimeZoneField.formfield
My preference is short and simple. This could be re-instated as an option.
Thansks to github.com/sidmitra https://github.com/brosner/django-timezones/pull/13/files
This causes problems when installing the package when all the dependencies aren't already there. setup.py is parsed - which looks for a version string - which then runs this __init__ - which then has to handle the imports, which if we haven't yet got our dependencies installed then they fail. If anyone knows a nice way to get around this, please let me know.
Getting ready to push a new release
Has a some nice helpers for 2 to 3 transition, namely, django.utils.six
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.