Added delete file/s in context menu in Commit view. #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOTE: Using this feature needs cookies enabled, which may sub-optimal in corporate controlled environments. TODO: The dependency on jQuery is overkill for something as simple as updating tracking mouse-ups on a input element.
Calling methods which are not properties through use of dot notation is a no-no in Apple's Objective-C 2.0 documentation. According to Apple it might work but the compiler will not warn about any dangerous use cases. The prominent example from the docs of how not to do it is "someObject.retain". Here retain is a method and not a property so proper use is "[someObject retain]". Unfortunately, often it is not clear if something in the API is merely an accessor or a method which acts like an accessor but does more than the name might imply. In this case, we can see this in PBEasyPipe where we have method calls like "NSTask.standardOutput = ...". Even though they may look correct this can be dangerous for obvious reasons. I assume hat this could also play a role in the appearance of the "bad file descriptor" messages.
This text label was sometimes cut off half in the last char depending on system font sizes.
Change default compiler to Clang v1.0 for up to 40% compile and runtime speed increase. Improve control over install location through user scripts and config files.
Also implements Finder's fade transitions, handles preview icon creation through GCD block dispatch and does the right thing regarding events: Mouse events go to the panel, key events to the fileBrowser outline view.
…ation from the selected row. Previously it would just start from the top of the file browser outline view every single time. Not very sexy...
This is not all that sortable as 1 year will sort before 2 minutes. To fix this the sorter on the table would neet to learn about units of time.
* When we are using subtree merge on git repository, GitX may show the slipped graph line. * Behind this glitch, GitX may leak the PBGitLane object.
The changes in PBViewController is only there to supress a compiler warning.
…ook panel hides during the repository window's auto refresh.
The net result is the same as of 10.5 when those were informal categories on NSObject.
Add rebase and pull menu items Get upstream name more git-accurately for upstream operations
Merge branch 'master' into fbartho Conflicts: PBGitIndex.m html/views/history/history.js
…'t match selectors, now it will only match <protocol>://<rest of url>
The conventional git commit message styling says to limit your first line to roughly 50 characters, and subsequent lines to 76 characters. The column guide in GitX doesn't support this. Implement 2 new hidden preferences, one to determine whether it uses a split column guide and the other to set the length of this guide. Default these preferences to NO and 76, respectively. When the split column guide is turned on, the drawing code will draw the normal column guide only for the first line and it will use the split column guide length for every other line.
Visual changes:
* Use a more structured table layout for the list of files.
Obj-C Code changes:
* Load the diffstat info with:
$ git show --numstat -M --summary --pretty=raw $REV
and then (as a 2nd, separate NSTask) load the full diff, with:
$ git show --pretty=raw -M --no-color $REV
* A side-effect of this is that you now get a list of files changed in a
merge commit, whereas it used to only show the commit message.
Javascript/HTML code changes:
* Get the commit view header info from the first task, so it should load
quicker, especially for commits with really long diffs.
* Use the --numstat info (from the output of the first NSTask) to get the
full list of files changed and the number of changed lines in each, and
the --summary info to see if any files were created/deleted.
* Add a "prototype" of the file-list element in index.html, and then have the
javascript extract then clone that, rather than building the elements
totally in code.
* Add javascript functions to show/hide the lines added/removed details when
the mouse hovers over the lines changed summary.
Also, better handle filenames with spaces
* Made the border color match the file diffs. * Made the background color lighter and the text darker, so it's easier to read (and doesn't have the slight look of being disabled that it used to have). * Changed the text shadow on the file names so it doesn't looks weird when overlapping a graph bar. In fact, now it helps readability in that case.
|
+1, but I think this needs a rebase first :) |
|
Just cherry pick it, and ignore my working branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/dmilith/gitx/commit/18f0ad716c60e7c04de98da690850f97141f8cf7