Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Marwan to website #264

Merged
merged 9 commits into from
Jun 17, 2024
Merged

Add Marwan to website #264

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c0c550d
Added info and images
marwanali55 Jun 7, 2024
0465dde
Marwan website image
marwanali55 Jun 7, 2024
43b1de3
Merge branch 'main' into add-marwan-to-website-3
marwanali55 Jun 7, 2024
5169537
Rename marwan_hover.JPG to marwan_hover.jpg
marwanali55 Jun 11, 2024
b792a97
Merge branch 'main' into add-marwan-to-website-3
marwanali55 Jun 11, 2024
928a656
Merge branch 'main' into add-marwan-to-website-3
marwanali55 Jun 13, 2024
6eab8df
Merge branch 'main' into add-marwan-to-website-3
marwanali55 Jun 17, 2024
bcf0440
Merge branch 'main' into add-marwan-to-website-3
galenwinsor Jun 17, 2024
a3a32bb
fix: yaml format
galenwinsor Jun 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions about/people.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,4 +457,13 @@ data:
brown_directory_uuid: 294d8182-b793-46ad-a6a8-6548b7378c2e
bio: Sanjana is a data science intern working with the Computational Biology Core at CCV. She is concentrating in Computational Biology ('26) and is interested in genetics and public health. She also loves to read sci-fi, run, and spend time with friends!
image: sanjana_main.jpg
- name: Marwan Ali
type: Part Time
team: Advanced Research Computing
subteam: Computational Biology Core
title: Data Science Intern
github_username: marwanali55
brown_directory_uuid: 80e72ea3-bce9-4685-bc2c-3041b55facfc
bio: Marwan is a summer intern working with the Computational Biology Core at CCV. He is an undergraduate student studying Applied Mathematics. He loves reading, playing piano, and writing stand-up comedy.
image: marwan_main.PNG
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This says the image will be a png file, but the images are jpgs. Take a look at the preview link (in a comment on the PR) and try to debug why your profile picture isn't showing up!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Ellen! Sorry about that; I just updated it to marwan_main.jpg. Please let me know if there are any other issues.


Binary file added images/people/marwan_hover.JPG
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one last thing: you need to make the jpg in this file lowercase to match marwan_main. Love the photo!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for letting me know Galen, I just made the change. Please reach out if anything else is needed.

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/people/marwan_main.jpg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading