ref: Pass photodiodeGhostBox as a const instead of function

brown-ccv · Dec 12, 2023 · 2ae8b3c · 2ae8b3c
1 parent 5a3f2ce
commit 2ae8b3c
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 12 deletions.
diff --git a/src/lib/markup/photodiode.js b/src/lib/markup/photodiode.js
@@ -7,16 +7,11 @@ import { div, span } from "./tags";
  * Markup for a box in the bottom right corner of the screen and a photodiode spot inside the ghost box
  * Note the box will only be visible if USE_PHOTODIODE is true
  */
-// TODO: Make constant
-// TODO #355: Conditional check should be at the task level
-function photodiodeGhostBox() {
-  const spot = span("", { id: "photodiode-spot", class: "photodiode-spot" });
-  return div(spot, {
-    id: "photodiode-box",
-    // Photodiode is only visible if config.USE_PHOTODIODE is true
-    class: config.USE_PHOTODIODE ? "photodiode-box visible" : "photodiode-box invisible",
-  });
-}
+const photodiodeGhostBox = div(span("", { id: "photodiode-spot", class: "photodiode-spot" }), {
+  id: "photodiode-box",
+  // Photodiode is only visible if config.USE_PHOTODIODE is true
+  class: config.USE_PHOTODIODE ? "photodiode-box visible" : "photodiode-box invisible",
+});
 
 /**
  * Conditionally flashes a spot inside the photodiodeGhostBox

diff --git a/src/timelines/honeycombBlock.js b/src/timelines/honeycombBlock.js
@@ -23,7 +23,7 @@ function buildHoneycombBlock(jsPsych) {
     stimulus: jsPsych.timelineVariable("stimulus"),
     // Conditionally displays the photodiodeGhostBox
     prompt: () => {
-      if (config.USE_PHOTODIODE) return photodiodeGhostBox();
+      if (config.USE_PHOTODIODE) return photodiodeGhostBox;
       else return null;
     },
     // Possible choices are the correct_responses from the task settings

diff --git a/src/trials/fixation.js b/src/trials/fixation.js
@@ -19,7 +19,7 @@ export function buildFixationTrial(jsPsych) {
     stimulus: div(div("", { id: "fixation-dot" }), { class: "center_container" }),
     // Conditionally display the photodiodeGhostBox
     prompt: () => {
-      if (config.USE_PHOTODIODE) return photodiodeGhostBox();
+      if (config.USE_PHOTODIODE) return photodiodeGhostBox;
       else return null;
     },
     response_ends_trial: false,