Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Eslint fails on warnings when running as a workflow #350

Merged
merged 4 commits into from
Dec 8, 2023

Conversation

RobertGemmaJr
Copy link
Member

  • Import order defaults to warnings now on eslint
  • Adds --max-warnings=0 to the lint command inside the pull_request.yml action

@RobertGemmaJr RobertGemmaJr self-assigned this Dec 8, 2023
@RobertGemmaJr RobertGemmaJr linked an issue Dec 8, 2023 that may be closed by this pull request
@RobertGemmaJr RobertGemmaJr requested review from anna-murphy, digicosmos86 and hetd54 and removed request for anna-murphy and digicosmos86 December 8, 2023 16:52
@RobertGemmaJr RobertGemmaJr changed the base branch from main to chore-import-order December 8, 2023 16:52
Copy link

github-actions bot commented Dec 8, 2023

Visit the preview URL for this PR (updated for commit a74dd02):

https://ccv-honeycomb--pr350-style-lint-action-safjupok.web.app

(expires Fri, 15 Dec 2023 16:56:44 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4ace1dcea913a952d2a1af84b94a4421bf36e610

Base automatically changed from chore-import-order to main December 8, 2023 17:08
@RobertGemmaJr RobertGemmaJr merged commit 1cbb0d5 into main Dec 8, 2023
8 checks passed
@RobertGemmaJr RobertGemmaJr deleted the style-lint-action branch December 8, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a separate .eslintrc file for local development and CI/CD
1 participant