fix: Only run release workflow when the release is created #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit e05ea1d): https://ccv-honeycomb--pr358-fix-releases-a5boyty5.web.app (expires Wed, 20 Dec 2023 18:28:09 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4ace1dcea913a952d2a1af84b94a4421bf36e610 |
|
It is possible to force change the commit a tag is associated with but the user will still have to create a new release in order for that change to take effect. |
broarr
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Releases must be tagged and a tag is always associated with 1 specific commit. Editing the release doesn't change the code it's using which means the executables will always be the exact same. If a user ever wanted to change the commit of a release they would have to delete the release, delete the tag, and then re-create the tag and release.
This is why I feel safe making this change. I have it in my TODOs to write a discussion post on the process of deleting and re-creating a release to change the commit it's built on!