Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/browser initialization, improved UI #27

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

ManojINaik
Copy link

This PR improves browser initialization and navigation handling:

  • Improved browser launch and initialization with updated settings
  • Enhanced error handling and logging
  • Fixed page initialization to avoid navigation conflicts
  • Added proper cleanup of resources
  • Improved context creation and state management
  • Added event listeners for popup handling

These changes make the browser more stable and reliable when handling navigation and page transitions.

@warmshao
Copy link
Collaborator

warmshao commented Jan 7, 2025

Hi, thank you for your PR. However, your commits have the following issues:

  1. You removed content from the main branch to resolve conflicts. Specifically, you deleted relevant information from the README. When resolving merge conflicts, it's crucial to carefully integrate changes and avoid deleting content from the target branch unintentionally.

  2. You deleted or modified things that didn't need changes. For example, you removed the .env.example file (which is important) and removed the emoji from the print statements (I actually like that emoji). Please only make changes that are necessary and directly related to the feature or bug fix you're addressing.

  3. You claimed to have "Improved browser launch and initialization with updated settings" and "Fixed page initialization to avoid navigation conflicts," and then made significant changes to CustomBrowser and CustomBrowserContext. However, I haven't encountered these issues myself. Before making such substantial changes, you need to demonstrate that these problems actually exist. Then we can discuss whether the changes are necessary. Your modifications make it difficult to expand in the future. You can refer to this PR: https://github.com/warmshao/browser-use-webui/pull/16, which is relatively much cleaner.

  4. Additionally, please try to limit each Pull Request to a single feature. This makes it much easier for me to review.

Thank you again!

@CLAassistant
Copy link

CLAassistant commented Jan 12, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants