Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use w3c protocol with latest client version #23

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Use w3c protocol with latest client version #23

wants to merge 10 commits into from

Conversation

avinash-bharti
Copy link
Collaborator

@avinash-bharti avinash-bharti commented Aug 25, 2022 •
edited
Loading

JIRA https://browserstack.atlassian.net/browse/ASI-4227
This PR:

  • Use latest appium client version
  • replace deprecated methods and locators
  • Use w3c configuration
  • updates information about appium version in readme

@avinash-bharti avinash-bharti marked this pull request as ready for review August 25, 2022 20:46
kamal-kaur04
kamal-kaur04 requested changes Aug 26, 2022
View reviewed changes
Copy link
Collaborator

@kamal-kaur04 kamal-kaur04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can have a single Base Class for all the three tests by leveraging <parameter> (can add conf.json file) tag in testng.xml config.

kamal-kaur04
kamal-kaur04 requested changes Aug 29, 2022
View reviewed changes
Copy link
Collaborator

@kamal-kaur04 kamal-kaur04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update README.md as we have removed separate directories. Can mention the direct command to run the test.

kamal-kaur04
kamal-kaur04 approved these changes Aug 29, 2022
View reviewed changes
Copy link
Collaborator

@kamal-kaur04 kamal-kaur04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tommybio
Tommybio reviewed Aug 29, 2022
View reviewed changes
Copy link

@Tommybio Tommybio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi java.net

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tommybio Tommybio Tommybio left review comments

@kamal-kaur04 kamal-kaur04 kamal-kaur04 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@avinash-bharti @kamal-kaur04 @Tommybio