Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Conform to Ansible > 2.10 #4

Merged
merged 64 commits into from
Mar 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
64 commits
Select commit Hold shift + click to select a range
c3dc106
style(attrauth): fix lint issues in playbook
brucellino Mar 21, 2024
1b05f4f
style(apache): fix ansible-lint issues in defaults and handlers
brucellino Mar 21, 2024
f67f9d4
style(apache): fix lint in OS-dependent configuration tasks
brucellino Mar 21, 2024
96af6c6
style(apache): fix linting issues in ssl config tasks
brucellino Mar 21, 2024
6ba7b11
style(apache): apply ansible-lint's opinionated fix to role
brucellino Mar 21, 2024
4795131
style(apache): align name of handler to respect ansible-lint rules
brucellino Mar 21, 2024
337084c
style(apache): apply lint fixes to main tasks
brucellino Mar 21, 2024
692f78a
style(comange-registry): apply linting rules to defaults
brucellino Mar 21, 2024
d683527
style(comange-registry): apply linting rules to configure tasks
brucellino Mar 21, 2024
5298707
style(comanage): declare no changes in ad-hoc commands
brucellino Mar 21, 2024
1d7a641
style(comanage): split long install command over several lines
brucellino Mar 21, 2024
ee4920e
style(comanage): apply linting fixes to install tasks
brucellino Mar 21, 2024
f72bd78
style(comanage): explicitly ignore idempotency in cache clear task
brucellino Mar 21, 2024
9c5d1b9
style(comanage): explicitly ignore idempotency in static files tasks
brucellino Mar 21, 2024
5b92db0
style(php): fix linting errors in role defaults
brucellino Mar 21, 2024
1a915c9
style(php): fix linting errors in role defaults
brucellino Mar 21, 2024
bd611e1
style(php): fix linting errors in role taks and vars
brucellino Mar 21, 2024
d7a68ff
style(shibboleth-sp): fix linting errors in role defaults
brucellino Mar 21, 2024
487bc87
style(shibboleth-sp): fix linting errors in role main tasks
brucellino Mar 21, 2024
37317a6
style(shibboleth-sp): fix all linting errors in role
brucellino Mar 21, 2024
9b30bf6
style(common): apply linting rules to role defaults
brucellino Mar 21, 2024
a928df2
style(common): apply linting rules to role defaults
brucellino Mar 21, 2024
8625292
style(common): fix linting errors in main role tasks
brucellino Mar 21, 2024
5a72a2c
style(common): apply linting fixes to role tasks and vars
brucellino Mar 21, 2024
0253042
style(ssp): make role defaults pass ansible lint
brucellino Mar 21, 2024
d07d960
chore(deps): freeze current requirements for dependabot
brucellino Mar 21, 2024
f7aa0a9
style(ssp): apply style rules to ssp handlers
brucellino Mar 21, 2024
e841ed0
style(ssp): reduce linting warnings in role composer tasks
brucellino Mar 21, 2024
75493df
style(ssp): apply linting rules to configure-common tasks
brucellino Mar 21, 2024
6b9dfde
style(ssp): ensure configure-saml and shib tasks pass lint
brucellino Mar 21, 2024
e4812da
style(ssp): ensure authservers playbook passes Ansible lint
brucellino Mar 21, 2024
f5ef550
style(authzkeys): conform to Ansible Lint style
brucellino Mar 21, 2024
f1e93c5
style(cache): conform to ansible style guide
brucellino Mar 21, 2024
865608b
style(cert2saml): conform to ansible style for ssp module role
brucellino Mar 21, 2024
735f337
style(comanage): conform comanage playbook and roles to Ansible style…
brucellino Mar 21, 2024
4bef6bf
style(d4science): conform playbook to Ansible lint
brucellino Mar 21, 2024
5465e6f
style(postgres): conform db playbook and postgres role to ansible lint
brucellino Mar 21, 2024
83c8e7a
style(egi-igtf): conform EGI IGTF role and playbook to Ansible Lint
brucellino Mar 21, 2024
c90dc6f
refactor(egi-igtf): move task to handler
brucellino Mar 21, 2024
db6f29d
style(deep2saml): conform playbook to Ansible Lint
brucellino Mar 21, 2024
543a844
style(federation-registry): conform to ansible lint
brucellino Mar 22, 2024
57e02f9
style(fedreg): conform to ansible lint
brucellino Mar 22, 2024
3b0661e
style(firewall): conform to ansible lint
brucellino Mar 22, 2024
c80d9d9
style(google2saml): conform to ansible lint
brucellino Mar 22, 2024
0bcb650
chore: ignore editor cruft
brucellino Mar 22, 2024
094d990
style(keycloak): conform to Ansible Lint
brucellino Mar 28, 2024
060b982
style(keycloak): conform to Ansible Lint
brucellino Mar 28, 2024
69c9959
style(metrics): conform metrics servers to Ansible Lint
brucellino Mar 28, 2024
ec4afe4
style(monservers): conform monservers to Ansible Lint
brucellino Mar 28, 2024
7ff5442
style(oauth2saml): conform to Ansible Lint
brucellino Mar 28, 2024
8774bd0
style(ldap): conform to Ansible Lint
brucellino Mar 28, 2024
e490dc5
style(orcid): conform to Ansible Lint
brucellino Mar 28, 2024
99931d2
style(rciam-keycloak,nginx,rsyslog,webproxy): conform to Ansible Lint
brucellino Mar 28, 2024
90faaa8
style(oidc): conform to Ansible Lint
brucellino Mar 28, 2024
40d04f6
style(registry-ui): conform to Ansible Lit
brucellino Mar 28, 2024
f91446e
style(registry): conform server playbook to Ansible Lint
brucellino Mar 28, 2024
08cd5c3
chore: add detect-secrets pre-commit hook
brucellino Mar 28, 2024
5845ea4
style(saml,oidc): conform to Ansible Lint
brucellino Mar 28, 2024
17ce338
style(secrets): conform to Ansible Lint
brucellino Mar 28, 2024
67196b4
style(site): conform to Ansible Lint
brucellino Mar 28, 2024
caeb0a7
style(ssp): conform to Ansible Lint
brucellino Mar 28, 2024
7ec5ab2
fix(apache): fix module name
brucellino Mar 28, 2024
20933b8
style(utils): conform to Ansible Lint
brucellino Mar 28, 2024
55a4ee0
style: conform to Ansible Lint
brucellino Mar 28, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .ansible-lint
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
exclude_paths:
- .pre-commit-config.yaml
- icingaagents.yml
- roles/common/handlers/main.yml
- authzkeys.yml
- inventories
offline: false
skip_list:
- role-name
6 changes: 5 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
.LSOverride

# Icon must end with two \r
Icon
Icon


# Thumbnails
._*
Expand All @@ -25,3 +26,6 @@ Network Trash Folder
Temporary Items
.apdisk
# END OSX.gitignore

# ignore editor cruft
.vscode
23 changes: 18 additions & 5 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,15 @@ repos:
- id: end-of-file-fixer
- id: check-yaml
- id: check-added-large-files
- id: requirements-txt-fixer

- repo: https://github.com/Yelp/detect-secrets
rev: v1.4.0
hooks:
- id: detect-secrets
args:
- --baseline
- .secrets.baseline

- repo: https://github.com/ansible-community/ansible-lint
rev: v24.2.1
Expand All @@ -18,11 +27,15 @@ repos:
exclude: .github
additional_dependencies:
- ansible-core>=2.16.0
args: [
"--exclude", ".pre-commit-config.yaml",
"--exclude", "roles/" # Exclude roles for now.
]

args:
- --exclude
- .pre-commit-config.yaml
- icingaagents.yml
# For some reason noqa is not being picked up on these files
- roles/common/handlers/main.yml
- authzkeys.yml
# ssp-modules is a bad name for a role
- roles/ssp-modules

- repo: https://github.com/python-jsonschema/check-jsonschema
rev: 0.28.0
Expand Down
Loading