Skip to content

Commit

Permalink
Fix prop interpolation
Browse files Browse the repository at this point in the history
What:

1) Change aria-label="{{`info-${id}`}}" to :aria-label="`info-${id}`"

Why:

1) Vue doesn't support interpolation inside regular attrs anymore
  • Loading branch information
bryce-mcmath committed Apr 2, 2020
1 parent 8e4574f commit 9e7dd53
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
{ 'footer-nav-button--dark': dark },
{ 'footer-nav-button--active': active }
]"
aria-label="{{`link to ${link}`}}"
:aria-label="`link to ${link}`"
>
<i :class="icon + ' footer-nav-button__icon'"></i>
</v-btn>
Expand Down
2 changes: 1 addition & 1 deletion client/src/components/info_slider/InfoSlider.vue
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
</v-btn>
<v-item-group v-model="onboarding" class="text-center" mandatory>
<v-item v-for="n in length" :key="`btn-${n}`" v-slot:default="{ active, toggle }">
<v-btn aria-label="{{`slide-photo-${n}`}}" :input-value="active" icon @click="toggle">
<v-btn :aria-label="`slide-photo-${n}`" :input-value="active" icon @click="toggle">
<v-icon>mdi-record</v-icon>
</v-btn>
</v-item>
Expand Down
2 changes: 1 addition & 1 deletion client/src/store/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ export default new Vuex.Store({
commit('setAjaxInProgress', false);
},

async setRankingsData({ commit, state }) {
async setRankingsData({ commit }) {
commit('setAjaxInProgress', true);
fetchRankingsData()
.then(rankData => {
Expand Down

0 comments on commit 9e7dd53

Please sign in to comment.