SCP: Another Random Act of Memory (Sanitization)

Clang's memory sanitizer found an off-by-one bug in sim_addr_acl_check while executing "testlib".
bscottm · Dec 1, 2023 · cf27dda · cf27dda
1 parent d235afe
commit cf27dda
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/sim_sock.c b/sim_sock.c
@@ -721,7 +721,7 @@ if (c != NULL) {
     if ((c - validate_addr) > sizeof (v_cpy) - 1)
         return status;
     memcpy (v_cpy, validate_addr, c - validate_addr);   /* Copy everything before the / */
-    v_cpy[1 + c - validate_addr] = '\0';                /* NUL terminate the result */
+    v_cpy[c - validate_addr] = '\0';                    /* NUL terminate the result */
     validate_addr = v_cpy;                              /* Use the original string minus the prefix specifier */
     }
 if (p_getaddrinfo(validate_addr, NULL, NULL, &ai_validate))