Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup smtp mail and add logging config #179

Merged
merged 9 commits into from
Jun 5, 2024

Conversation

arminpatel
Copy link
Collaborator

@arminpatel arminpatel commented Apr 25, 2024

Overview

  1. This PR fixes [Feature Request]: setup logging in django #171 .
  2. This PR does the following: setup smtp and logging

Essential Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
  • The PR is made from a branch that's not called "main/master".

Proof that changes are correct

PR Pointers

  • If you need a review or an answer to a question, and don't have permissions to assign people, leave a comment like the following: "{{Question/comment}} @{{reviewer_username}} PTAL".
  • Never force push. If you do, your PR will be closed.

Copy link

netlify bot commented Apr 25, 2024

Deploy Preview for merch-site canceled.

Name Link
🔨 Latest commit ecc2e5f
🔍 Latest deploy log https://app.netlify.com/sites/merch-site/deploys/6629f88e70e7f3000804239a

@Priyansh61
Copy link
Collaborator

@arminpatel should we continue builiding this feature in new branch and then merge it to main once it is done? Or should we merge it to the main?

@arminpatel
Copy link
Collaborator Author

arminpatel commented Apr 26, 2024

@arminpatel should we continue builiding this feature in new branch and then merge it to main once it is done? Or should we merge it to the main?

@Priyansh61 what additional features are you thinking of? imo logging should be merged asap

@arminpatel arminpatel merged commit b6c6cc3 into bsoc-bitbyte:main Jun 5, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: setup logging in django
3 participants