-
-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix supporters partial and remove it from Forms page #1463
Conversation
Maybe the Vuepress dev build didn't like the whitespaces inside the SVG and the mixed indentation in the HTML part. Works for me locally now and fixes #1459. Removed the supporters partial from the Forms page, because I assume it was a copy&paste leftover.
Thanks! Fixes the bug for me on the frontpage but not on Guide.md here http://localhost:8081/Guide/ |
Yeah integration section is still broken locally, and it's definetely not done in #1457 as it was there before that. |
@pavlenex interesting, for me integrations and plugins work unlike on your screenshot. Did you modify anything? Also did you run I use nodeJS v20 and you? |
Can both of you run |
Damn cache, it works now 👍 🤗 |
Nuked every possible thing, cleared cache, updated everything, nodejs v.22 Guide page is back! So it was cache/nodejs issue probably. However plugins and integrations aren't which must be related to When I run it I get this Which could lead you to believe there are no errors, but if you check the last line it says
I have no idea what that means but that's the only thing from my logs that are akward when setting things up. Full logs
@dennisreimann any ideas? |
It looks like you are running into this: https://stackoverflow.com/questions/39325759/sed-on-mac-extra-characters-after-p-command Can you pull again, run |
Works now! 🚀 |
@pavlenex tried to reproduce by deleting deps folder and running, setup-deps.sh and it worked for me. Maybe try to |
Maybe the Vuepress dev build didn't like the whitespaces inside the SVG and the mixed indentation in the HTML part.
Works for me locally now and fixes #1459.
Removed the supporters partial from the Forms page, because I assume it was a copy&paste leftover.