-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add context for fetch process #57
base: develop
Are you sure you want to change the base?
Conversation
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## develop #57 +/- ##
===========================================
- Coverage 13.62% 13.60% -0.02%
===========================================
Files 11 11
Lines 1431 1433 +2
===========================================
Hits 195 195
- Misses 1180 1182 +2
Partials 56 56
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
The ctx parameter in the CommitStates function is not used.
c8d0178
to
c072d63
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lack of actual use and change of context
consensus/bor/bor.go
Outdated
@@ -1205,6 +1209,7 @@ func (c *Bor) fetchAndCommitSpan( | |||
|
|||
// CommitStates commit states | |||
func (c *Bor) CommitStates( | |||
ctx context.Context, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Parameter not used
No description provided.