Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context for fetch process #57

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ClarkChenc
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2023

Codecov Report

Merging #57 (c072d63) into develop (97ef7d9) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##           develop      #57      +/-   ##
===========================================
- Coverage    13.62%   13.60%   -0.02%     
===========================================
  Files           11       11              
  Lines         1431     1433       +2     
===========================================
  Hits           195      195              
- Misses        1180     1182       +2     
  Partials        56       56              
Files Changed Coverage Δ
consensus/bor/bor.go 2.32% <0.00%> (-0.01%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

bladehan1
bladehan1 previously approved these changes Sep 14, 2023
@bladehan1 bladehan1 dismissed their stale review September 14, 2023 01:39

The ctx parameter in the CommitStates function is not used.

Copy link
Contributor

@bladehan1 bladehan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lack of actual use and change of context

@@ -1205,6 +1209,7 @@ func (c *Bor) fetchAndCommitSpan(

// CommitStates commit states
func (c *Bor) CommitStates(
ctx context.Context,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parameter not used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants