Fix/325 photo essay block styles in 5.7 #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dding-top technique In 5.4 the :after element was used to do this but in 5.7 the block editor is using the :after element for block outlines and we need a new element to force the child blocks to have height.
acketon
changed the base branch from
develop
to
wp-upgrade/5.7-base-compatibility
gcharlie
approved these changes
Mar 31, 2023
…ssay-block-styles-in-5.7 # Conflicts: # dist/blocks.build.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #325
In WP 5.4 and earlier an :after element was used to force the child blocks to have a specific height via the padding-top technique. But in WP 5.7 the block editor has started using an :after element on the same DOM element for block outlines. This caused the blocks to collapse to 0px height.
Ideally I think it's time to rebuild this block to use flexbox now that browser support is much better than in 2019 when this was originally built. The block's CSS could probably be simplified quite a bit if we did that in a future update.