Add StackMapTable support #1
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we encounter a GOTO instruction for which we haven't encountered the label yet, then we don't know its stackDiff contribution until after the continuation traversal has finished. That's why we reset the stackSize and maxStack counters and compensate for this later on when we know the stackDiff contribution of the branching instruction.
Makes it obvious what values are actually needed.
It turns out seen labels are actually read on return.
Computing it conditionally is still left to be done.
igstan
force-pushed
the
stack-map-table
branch
from
a7a96e1 to
06b2f04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.