Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: changed transaction handling related to Environment package and Auth package #1501

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

kakcy
Copy link
Contributor

@kakcy kakcy commented Feb 4, 2025

This pull request focuses on refactoring the authService and EnvironmentService structures to use storage interfaces instead of creating new instances within methods. This change improves code maintainability and testability. The most important changes include updating the authService and EnvironmentService structures, modifying various methods to use the new storage interfaces, and updating related tests.

Part of #1474

@kakcy kakcy changed the title refactor: changed transaction handling related to Environment package refactor: changed transaction handling related to Environment package and Auth package Feb 6, 2025
@kakcy kakcy marked this pull request as ready for review February 6, 2025 10:04
@kakcy kakcy marked this pull request as draft February 19, 2025 09:58
@kakcy kakcy force-pushed the update-storage-client-environment branch from 7a7aca1 to 54c3822 Compare February 26, 2025 05:20
@kakcy
Copy link
Contributor Author

kakcy commented Feb 26, 2025

In the previous refactoring, the transaction instance was obtained from Qe(), but we have modified it so that if the transaction instance can be obtained from the Context received within each query execution function, the query will be executed based on it.

This modification has the following effects:

@kakcy kakcy removed the request for review from kentakozuka February 27, 2025 04:47
@kakcy kakcy force-pushed the update-storage-client-environment branch from 788bb8c to fbd1988 Compare March 6, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant