Update to Protobuf v27.3 #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timostamm
commented
Aug 15, 2024
Comment on lines
+54
to
+63
| // Returning a runtime error for the test Required.Proto3.ProtobufInput.UnknownOrdering.ProtobufOutput | ||
| // crashes the runner. | ||
| if ( | ||
| is_Required_Proto3_ProtobufInput_UnknownOrdering_ProtobufOutput(request) | ||
| ) { | ||
| return { | ||
| case: "protobufPayload", | ||
| value: new Uint8Array(), | ||
| }; | ||
| } |
There was a problem hiding this comment.
This is a bug in the conformance runner. The test protocol allows clients to reply with a runtime error, which is considered a test failure. This specific test however does not allow the client to do so, and prematurely exits the test suite, making it impossible to skip or mark the test as known failing.
smaye81
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update runs tests for Editions for implementations that support them. Tests for proto2 and proto3 always run.
v27.0 updated
test_messages_proto2.prototo include an extension using a group. Unfortunately, protobuf.js is unable to parse the file, causing allproto2tests to fail.