Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ValidationResult#isSuccess() when result is success #27

Merged
merged 3 commits into from
Sep 11, 2023
Merged

Fix ValidationResult#isSuccess() when result is success #27

merged 3 commits into from
Sep 11, 2023

Conversation

wreulicke
Copy link
Contributor

@wreulicke wreulicke commented Sep 1, 2023 •
edited
Loading

Is this just a bug?
expected: violations.isEmpty() => validation is success
current: violations.isEmpty() => validation is not success

I think so according to this example.
https://github.com/bufbuild/protovalidate-java#example

@CLAassistant
Copy link

CLAassistant commented Sep 1, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

rodaine
rodaine approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@rodaine rodaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and good catch!

@rodaine rodaine merged commit 63d2c4b into bufbuild:main Sep 11, 2023
3 checks passed
@wreulicke wreulicke deleted the patch-1 branch September 12, 2023 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodaine rodaine rodaine approved these changes

@pkwarren pkwarren pkwarren approved these changes

@Alfus Alfus Awaiting requested review from Alfus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wreulicke @CLAassistant @pkwarren @rodaine