Dependency update and migration to AndroidX #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
November 28, 2018 13:42
2) Git ignore file was updated. 3) A change log file was added.
…ns-plugin) was added to check for dependency updates. 2) Java compatibility upgraded to Java 1.8. 3) Unused definitions for a presentation layer that does not exist anymore were removed.
|
Very good migration but I am unable to execute instrumental tests |
1) Mockito Android 2.23.x is not compatible with current stable Android Gradle Plugin. Android Gradle Plugin 3.3.0-beta02 or higher is needed. See: mockito/mockito#1511 2) Koin 1.0.2 makes browser activity tests fail. It is probably an issue with the updated declareMock function. See: InsertKoinIO/koin#243
|
Hi,
Thanks for pointing this problem, |
|
Hi @xmellado thanks for response :) I've been trying to solve it by myself, and I submitted an issue to Koin team. Here you can view the issue https://github.com/InsertKoinIO/koin/issues/326 |
|
Hi, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I will use your template for a new project at work and we have decided to update its dependencies. I have updated all library versions and migrate everything to AndroidX, including tests. There is a changelog file with all the changes and I have added a plugin for checking dependency updates.
I hope you find it useful,
Xavi