-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tests and tested versions to cover Ruby 3.4 and Rails 8 #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ils error message
features/fixtures/rails8/app/app/controllers/active_job_controller.rb
Dismissed
Show dismissed
Hide dismissed
features/fixtures/rails8/app/app/controllers/api_key_controller.rb
Dismissed
Show dismissed
Hide dismissed
features/fixtures/rails8/app/app/controllers/app_type_controller.rb
Dismissed
Show dismissed
Hide dismissed
features/fixtures/rails8/app/app/controllers/app_version_controller.rb
Dismissed
Show dismissed
Hide dismissed
features/fixtures/rails8/app/app/controllers/auto_notify_controller.rb
Dismissed
Show dismissed
Hide dismissed
features/fixtures/rails8/app/app/controllers/project_root_controller.rb
Dismissed
Show dismissed
Hide dismissed
features/fixtures/rails8/app/app/controllers/release_stage_controller.rb
Dismissed
Show dismissed
Hide dismissed
features/fixtures/rails8/app/app/controllers/send_code_controller.rb
Dismissed
Show dismissed
Hide dismissed
features/fixtures/rails8/app/app/controllers/send_environment_controller.rb
Dismissed
Show dismissed
Hide dismissed
features/fixtures/rails8/app/app/controllers/session_tracking_controller.rb
Dismissed
Show dismissed
Hide dismissed
tomlongridge
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
With the releases of Ruby 3.4 and Rails 8 we need to ensure that the test setups run correctly on those versions. To that end, this PR:
{a: 1}
as a string is'{a: 1}'
in 3.4, where it was'{:a => 1}'
previously)Changeset
The majority of the changeset is the rails8 app addition. I would suggest skimming everything in the
features/fixtures/rails8/app
directory as a lot of it will be generated from the rails application, and the rest will be identical to rails6/7 setups.Notes
There are a few changes worth commenting on:
java.lang.Throwables
are processed correctly as this test fails when running on CI, but not locally. A ticket has been created to examine this further at a later date.