Hard fail ECR check #2526
Merged
Hard fail ECR check #2526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview URL: https://2526--bk-docs-preview.netlify.app |
ellsclytn
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that all CVEs have been triaged and we have 0 reported in the pipeline - we are ready to switch off Vanta checks. Before we do that - we need to make ECR scan results check hard-fail.
The plugin has support for providing inline help text to triage vulnerabilities. In the meantime - have a look at this PR for how we propose to triage CVEs: https://github.com/buildkite/guide/pull/285
Verification
New High and Critical CVEs will start failing builds.
Deployment
No risk, pipeline change only.
Rollback
Revert this PR (make the step soft-fail).