Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example of GraphQL cursor-based pagination #2560

Closed
wants to merge 2 commits into from

Conversation

tomowatt
Copy link
Member

Based on feedback received and a lack of an example where it mentions utilizing Pagination

@buildkite-docs-bot
Copy link
Contributor

Preview URL: https://2560--bk-docs-preview.netlify.app

Copy link
Contributor

@mbelton-buildkite mbelton-buildkite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good information to include, but I feel like it's not in the right spot. The page it's on talks about limits, and while this is a technique for dealing with limits, it's useful information across the GraphQL API in general.

I think it would be good to move it to the Overview page, and rework the Relay compatibility section to be the "Pagination" section. It would mention complying with the Relay specification, then use your content here as an example. We could then link to it from this page where it mentions "pagination."

What do you think? I'm happy to help make it work there if you need. 😊

@tomowatt
Copy link
Member Author

@mbelton-buildkite yeah that sounds great to me, I was initially stuck to where to put the example and didn't want to start moving things about/making a mess 😄

@gilesgas gilesgas self-requested a review January 31, 2024 23:56
@tomowatt tomowatt closed this Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants