Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PS-222 fix bug introducted in commit 7168e04 #132

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

SorchaAbel
Copy link
Contributor

@SorchaAbel SorchaAbel commented Dec 31, 2024

Fix failing spec introduced in #7168e04
ref #131

@SorchaAbel SorchaAbel marked this pull request as ready for review December 31, 2024 01:33
Copy link
Contributor

@CerealBoy CerealBoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 🚀

@SorchaAbel
Copy link
Contributor Author

@thejcannon are you happy with this change? Many thanks and happy new year :)

@thejcannon
Copy link
Contributor

LGTM!

@SorchaAbel SorchaAbel merged commit 563708b into main Jan 2, 2025
1 check passed
@SorchaAbel SorchaAbel deleted the PS-222-fix-failing-spec branch January 2, 2025 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants