Update cosign #1201
Merged
Update cosign #1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Natalie Arellano <[email protected]>
Comment on lines
+114
to
+115
| permissions: | ||
| id-token: write |
There was a problem hiding this comment.
Comment on lines
+9
to
+10
| permissions: | ||
| contents: write |
There was a problem hiding this comment.
I updated the repo "Actions permissions" settings to use the more restrictive "Read repository contents and package permissions" instead of the more permissive "Read and write permissions", thus this is now required.
jabrown85
approved these changes
Sep 18, 2023
Signed-off-by: Natalie Arellano <[email protected]>
natalieparellano
force-pushed
the
update-cosign
branch
from
d606d00 to
cd39528
Compare
Signed-off-by: Natalie Arellano <[email protected]>
natalieparellano
added a commit
that referenced
this pull request
Dec 14, 2023
In #1201 we explicitly granted the needed permissions to the token, and we updated the repo settings to be the most restrictive. Now that the repo has been updated, the draft-release workflow is broken for minor versions less than 0.18.x. This change will allow us to continue to patch 0.17.x. Signed-off-by: Natalie Arellano <[email protected]>
natalieparellano
added a commit
that referenced
this pull request
Jan 10, 2024
…ons (#1256) In #1201 we explicitly granted the needed permissions to the token, and we updated the repo settings to be the most restrictive. Now that the repo has been updated, the draft-release workflow is broken for minor versions less than 0.18.x. This change will allow us to continue to patch 0.17.x. Signed-off-by: Natalie Arellano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates GitHub actions workflows that use
cosignto sign and verify lifecycle images to use keyless signing. This is the default as ofcosign2.x.x and is considered more secure than signing with a long-lived private key. Note that thecosign verifycommand for verifying signatures is also updated.When this is merged, we can remove
COSIGN_PASSWORDandCOSIGN_PRIVATE_KEYfrom repo secrets. We'll also need to update our Docker Hub page help text with the new information.Release notes
cosign, use keyless signingRelated
Resolves #___
Context
Tested (with some effort) on fork: https://github.com/natalieparellano/lifecycle/actions