Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Simplify go:build constraint
linux || darwin
tounix
. This can potentially support also constraintfreebsd
in the future.The constraint
unix
is available since Go 1.19: https://tip.golang.org/doc/go1.19#go-unixFile name suffixes (filename_unix.go, filename_windows.go, filename_linux.go ...) are also available and being used in this project, but I'm not sure whether one should do both (go:build and file name suffixes) OR not. But it seems like
go:build
takes precedence.Related
Kind of related: #1271
Context
I'm working on getting support for
FreeBSD
. This patch helps to simplify the code base so that the diff for FreeBSD support gets smaller.