Remove Windows Support #1441
Open
Remove Windows Support #1441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I took a swing at removing any and all references to windows in this reference implementation. Lifecycle no longer outputs a windows binary as a release artifact Lifecycle no longer operates against windows containers buildpacks/rfcs#311 https://medium.com/buildpacks/deprecation-announcement-windows-container-feature-in-cloud-native-buildpacks-bbb70351343d Signed-off-by: Jesse Brown <[email protected]>
joeybrown-sf
approved these changes
Dec 18, 2024
Signed-off-by: Jesse Brown <[email protected]>
jkutner
reviewed
Dec 20, 2024
| @@ -486,7 +486,7 @@ func testAnalyzer(platformAPI string) func(t *testing.T, when spec.G, it spec.S) | |||
|
|
|||
| it("populates target metadata from the run image", func() { | |||
| h.AssertNil(t, previousImage.SetLabel("io.buildpacks.base.id", "id software")) | |||
| h.AssertNil(t, previousImage.SetOS("windows")) | |||
| h.AssertNil(t, previousImage.SetOS("zindows")) | |||
There was a problem hiding this comment.
I wanted to rid ourselves of any references to the string windows - I mostly did it as I removed all references but decided to leave it so it was clear we don't actually support windows OS images in this repo.
jkutner
reviewed
Dec 20, 2024
| @@ -744,7 +744,7 @@ func testDetector(t *testing.T, when spec.G, it spec.S) { | |||
| Targets: []buildpack.TargetMetadata{ | |||
| {Arch: "P6", ArchVariant: "Pentium Pro", OS: "Win95", | |||
| Distros: []buildpack.OSDistro{ | |||
| {Name: "Windows 95", Version: "OSR1"}, {Name: "Windows 95", Version: "OSR2.5"}}}, | |||
| {Name: "Sceens 95", Version: "OSR1"}, {Name: "Sceens 95", Version: "OSR2.5"}}}, | |||
There was a problem hiding this comment.
Same as #1441 (comment)
jkutner
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I took a swing at removing any and all references to windows in this reference implementation. There are for sure areas that can be cleaned up and reduce complexity further. This was a first pass to get things compiling and actions working.
Release notes
Windows support has been removed from lifecycle. Lifecycle no longer outputs a windows binary as a release artifact Lifecycle no longer operates against windows containers.
Related
buildpacks/rfcs#311
Context
https://medium.com/buildpacks/deprecation-announcement-windows-container-feature-in-cloud-native-buildpacks-bbb70351343d