fixing some feedback from review

Signed-off-by: Juan Bustamante <[email protected]>
buildpacks · Dec 20, 2023 · 3c598f4 · 3c598f4
1 parent 16e645d
commit 3c598f4
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/pkg/archive/archive_test.go b/pkg/archive/archive_test.go
@@ -472,7 +472,7 @@ func testArchive(t *testing.T, when spec.G, it spec.S) {
 				h.AssertOnTarEntries(t, outputFilename,
 					"/nested/dir/original-file",
 					"/nested/dir/original-file-2",
-					h.HardLinks(),
+					h.AreEquivalentHardLinks(),
 				)
 			})
 		})

diff --git a/pkg/buildpack/buildpack_test.go b/pkg/buildpack/buildpack_test.go
@@ -527,7 +527,7 @@ version = "1.2.3"
 				os.RemoveAll(filepath.Join(bpRootFolder, "original-file-2"))
 			})
 
-			it.Focus("hardlink is preserved in the output tar file", func() {
+			it("hardlink is preserved in the output tar file", func() {
 				bp, err := buildpack.FromBuildpackRootBlob(
 					blob.NewBlob(bpRootFolder),
 					archive.DefaultTarWriterFactory(),
@@ -540,7 +540,7 @@ version = "1.2.3"
 				h.AssertOnTarEntries(t, tarPath,
 					"/cnb/buildpacks/bp.one/1.2.3/original-file",
 					"/cnb/buildpacks/bp.one/1.2.3/original-file-2",
-					h.HardLinks(),
+					h.AreEquivalentHardLinks(),
 				)
 			})
 		})

diff --git a/testhelpers/tar_assertions.go b/testhelpers/tar_assertions.go
@@ -136,7 +136,7 @@ func SymlinksTo(expectedTarget string) TarEntryAssertion {
 	}
 }
 
-func HardLinks() TarEntriesAssertion {
+func AreEquivalentHardLinks() TarEntriesAssertion {
 	return func(t *testing.T, header1 *tar.Header, _ []byte, header2 *tar.Header, _ []byte) {
 		t.Helper()
 		if header1.Typeflag != tar.TypeLink && header2.Typeflag != tar.TypeLink {