Hardlinks are dereferenced in generated archives #1896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type/enhancement
jjbustamante
force-pushed
the
bugfix/jjbustamante/issue-1286
branch
from
f7c6c6e to
0b8c317
Compare
jjbustamante
commented
Sep 11, 2023
| } | ||
|
|
||
| _, err = tw.Write(buf) | ||
| _, err = io.Copy(tw, tr) |
There was a problem hiding this comment.
I noticed this line could throw the same error reported here
jjbustamante
commented
Sep 11, 2023
jjbustamante
force-pushed
the
bugfix/jjbustamante/issue-1286
branch
from
0b8c317 to
9f8044d
Compare
There was a problem hiding this comment.
@jjbustamante it's cool to see this taking shape. I left a couple comments in case it's helpful
jjbustamante
force-pushed
the
bugfix/jjbustamante/issue-1286
branch
from
e3a6ac6 to
074967a
Compare
jjbustamante
added
type/bug
github-actions
bot
added
the
type/enhancement
jjbustamante
force-pushed
the
bugfix/jjbustamante/issue-1286
branch
4 times, most recently
from
232de13 to
76fb460
Compare
jjbustamante
removed
the
type/enhancement
Signed-off-by: Juan Bustamante <[email protected]>
Co-authored-by: Natalie Arellano <[email protected]> Signed-off-by: Juan Bustamante <[email protected]>
Signed-off-by: Juan Bustamante <[email protected]>
jjbustamante
force-pushed
the
bugfix/jjbustamante/issue-1286
branch
from
76fb460 to
5f5f2af
Compare
github-actions
bot
added
the
type/enhancement
Signed-off-by: Juan Bustamante <[email protected]>
There was a problem hiding this comment.
Nice work @jjbustamante - I left one comment/question about the test assertion, but this seems just about ready. Hats off to you for figuring out the Windows stuff.
Signed-off-by: Juan Bustamante <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1896 +/- ##
==========================================
- Coverage 79.69% 79.64% -0.05%
==========================================
Files 172 174 +2
Lines 13046 13126 +80
==========================================
+ Hits 10396 10453 +57
- Misses 1995 2010 +15
- Partials 655 663 +8
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a fix to handle hardlinks included into a buildpack when
pack buildpack packageis executed.Output
Before
large-fileandlarge-file2references the same file with a hardlink, we can notice the size of the buildpack image is bigger than expected because the hardlink is lost during the image creation.Using dive, we can see:
After
After the fix is applied, the final image size is as expected not duplicating the files
Using dive, we can see:
Documentation
Related
Resolves #1286