Simplifies acceptance tests by moving fixtures up one directory #1911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At some point, we might have intended to have different fixtures per Buildpack API version. However, we have only ever had one sub-folder (0.2). With the lifecycle dropping support for Buildpack API versions less than 0.7, we should rename or remove this sub-folder. Opting to remove it, to avoid having to rename it in the future. Signed-off-by: Natalie Arellano <[email protected]>
github-actions
bot
added
type/enhancement
jkutner
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
At some point, we might have intended to have different fixtures per Buildpack API version.
However, we have only ever had one sub-folder (0.2).
With the lifecycle dropping support for Buildpack API versions less than 0.7, we should rename or remove this sub-folder.
Opting to remove it, to avoid having to rename it in the future.
This will fix lifecycle CI failures such as https://github.com/buildpacks/lifecycle/actions/runs/6235862018/job/16926424658#step:8:188