Allow the build to proceed with /cnb/lifecycle/creator when the order contains extensions #1983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… contains extensions The creator will error if the detected group contains extensions, but if no extensions detect then the build can proceed and potentially succeed. This avoids end-user headaches when popular builders contain extensions (see buildpacks/community#244) but the extensions don't detect by default (and hence using the creator is just fine). Signed-off-by: Natalie Arellano <[email protected]>
github-actions
bot
added
the
type/enhancement
jjbustamante
reviewed
Dec 1, 2023
| @@ -281,7 +281,7 @@ func (l *LifecycleExecution) Run(ctx context.Context, phaseFactoryCreator PhaseF | |||
| return l.Export(ctx, buildCache, launchCache, kanikoCache, phaseFactory) | |||
| } | |||
|
|
|||
| if l.platformAPI.AtLeast("0.10") && l.hasExtensions() { | |||
| if l.platformAPI.AtLeast("0.10") && l.hasExtensions() && !l.opts.UseCreatorWithExtensions { | |||
| return errors.New("builder has an order for extensions which is not supported when using the creator") | |||
There was a problem hiding this comment.
I wonder if we can improve the error message to give some guidance to end-users on what's going on or what they can do to fix it.. maybe a link to some documentation?
There was a problem hiding this comment.
Thanks for the suggestion - I updated the error message in c351409
Signed-off-by: Natalie Arellano <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1983 +/- ##
==========================================
+ Coverage 79.51% 79.52% +0.01%
==========================================
Files 174 174
Lines 13074 13077 +3
==========================================
+ Hits 10395 10398 +3
Misses 2016 2016
Partials 663 663
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Juan Bustamante <[email protected]>
Signed-off-by: Juan Bustamante <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Note that this will have no effect until there is a lifecycle 0.19.0 - but, we can prepare for it now)
The creator will error if the detected group contains extensions, but if no extensions detect then the build can proceed and potentially succeed.
This avoids end-user headaches when popular builders contain extensions (see buildpacks/community#244) but the extensions don't detect by default (and hence using the creator is just fine).
Related lifecycle PR: buildpacks/lifecycle#1246