Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated stack validation #2285

Conversation

adwait-godbole
Copy link

Summary

Continues with a warning instead of an error

Output

Warning: No schema version declared in project.toml, defaulting to schema version 0.1
latest: Pulling from paketobuildpacks/builder-jammy-base
Digest: sha256:a298c00780bd587a8867adbaed0baf6196b3b114f635acb7d2c33455327f6f46
Status: Image is up to date for paketobuildpacks/builder-jammy-base:latest
latest: Pulling from buildpacks/builder/php
Digest: sha256:91065e07a53b1c048fcaf8e49936a9d19c388b2dfdf2e7e589885aab2f5aae79
Status: Image is up to date for gcr.io/buildpacks/builder/php:latest
Warning: run-image stack id 'google' does not match builder stack 'io.buildpacks.stacks.jammy' (deprecated usage of stack)

Before

build process was exiting giving an error message

After

build process continues with a warning

Related

Continuation of PR #2119

Fixes #2104

@adwait-godbole adwait-godbole requested review from a team as code owners November 17, 2024 15:33
@github-actions github-actions bot added this to the 0.36.0 milestone Nov 17, 2024
@github-actions github-actions bot added type/enhancement Issue that requests a new feature or improvement. type/chore Issue that requests non-user facing changes. labels Nov 17, 2024
@jjbustamante jjbustamante removed this from the 0.36.0 milestone Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/chore Issue that requests non-user facing changes. type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove validation of deprecated io.buildpacks.stack.id
2 participants