Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/custom query #17

Merged
merged 8 commits into from
Feb 28, 2024
Merged

Feat/custom query #17

merged 8 commits into from
Feb 28, 2024

Conversation

Peartes
Copy link
Contributor

@Peartes Peartes commented Jan 15, 2024

This PR adds into the contract custom query serialization to the chain

@Peartes Peartes added bug Something isn't working enhancement New feature or request labels Jan 15, 2024
@Peartes Peartes self-assigned this Jan 15, 2024

#[derive(Serialize, Deserialize, Clone, Debug, PartialEq, JsonSchema)]
#[serde(rename_all = "snake_case")]
pub enum MyCustomQuery {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks great, lets just change the name of this type to something more descriptive, like WebAuthNCustomQuery or XionCustomQuery

@Peartes Peartes requested a review from ash-burnt January 17, 2024 16:54
@ash-burnt ash-burnt merged commit 1cbe8fa into main Feb 28, 2024
2 checks passed
@ash-burnt ash-burnt deleted the feat/custom-query branch February 28, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants