Refactor Abstraxion to fetch config #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2ab0bac The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Signed-off-by: Burnt Val <[email protected]>
justinbarry
reviewed
Mar 22, 2024
| @@ -87,7 +96,7 @@ export function AbstraxionSignin(): JSX.Element { | |||
| } | |||
| urlParams.set("redirect_uri", currentUrl); | |||
| const queryString = urlParams.toString(); // Convert URLSearchParams to string | |||
| window.location.href = `${dashboardUrl}?${queryString}`; | |||
| window.location.href = `https://${dashUrl}?${queryString}`; | |||
There was a problem hiding this comment.
The dashboard URL might be local, should include the protocol in the passed var
justinbarry
reviewed
Mar 22, 2024
packages/constants/src/index.ts
Outdated
| // If mainnet chain-id/network changes be sure to update here. | ||
| const DASHBOARD_URLS = { | ||
| "xion-mainnet-1": "dashboard.burnt.com", | ||
| "xion-testnet-1": "testnet-dashboard.burnt.com", |
There was a problem hiding this comment.
Suggested change
| "xion-testnet-1": "testnet-dashboard.burnt.com", | |
| "xion-testnet-1": "testnet.dashboard.burnt.com", |
There was a problem hiding this comment.
I can make this change but I was under the impression that we wanted to stay away from using too many "." and thus the reason for the hyphenated sub-domain
justinbarry
requested changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.