-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Receive functionality for dashboard #135
Conversation
BurntNerve
commented
Mar 20, 2024
- Added receive modal for dashboard
![Screenshot 2024-03-20 at 9 22 24 AM](https://private-user-images.githubusercontent.com/28539040/314535725-81260247-5aa5-487e-838a-7e49ce0a80e5.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxNTk5MTUsIm5iZiI6MTczOTE1OTYxNSwicGF0aCI6Ii8yODUzOTA0MC8zMTQ1MzU3MjUtODEyNjAyNDctNWFhNS00ODdlLTgzOGEtN2U0OWNlMGE4MGU1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEwVDAzNTMzNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTNhMTUxYWNmNWJhMTM3NzFiZjQxYjdhMDY1ODk0Nzk0NDcyNGU4YTM4ODNhNjAzNzAyODMzYzUwOWEyYTkxZTgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.g8DaZbLZd5QIoOTXURoet8Qwu2_zyRbgknW3AdQSGNM)
🦋 Changeset detectedLatest commit: 6ea54fc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
||
export const XION_TO_USDC_CONVERSION = 50; | ||
|
||
export const Overview = () => { | ||
export const Overview = ({ account }: { account?: AbstraxionAccount }) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason for pulling this in as prop as opposed to getting value from context or useAccount hook?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not necessarily a huge reason for one over the other. I could switch it so there is less prop drilling, was just following what was already done in AccountInfo component.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was just curious. I had prop drilled because I couldn't get the parent component to update the balance after performing a send tx in the child component so was curious if you were seeing similar stale data issues. All good though