Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Receive functionality for dashboard #135

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Added Receive functionality for dashboard #135

merged 2 commits into from
Mar 20, 2024

Conversation

BurntNerve
Copy link
Contributor

  • Added receive modal for dashboard
Screenshot 2024-03-20 at 9 22 24 AM

Copy link

changeset-bot bot commented Mar 20, 2024

🦋 Changeset detected

Latest commit: 6ea54fc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
abstraxion-dashboard Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
xion-js-abstraxion-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2024 2:46pm
xion-js-demo-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2024 2:46pm


export const XION_TO_USDC_CONVERSION = 50;

export const Overview = () => {
export const Overview = ({ account }: { account?: AbstraxionAccount }) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for pulling this in as prop as opposed to getting value from context or useAccount hook?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessarily a huge reason for one over the other. I could switch it so there is less prop drilling, was just following what was already done in AccountInfo component.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was just curious. I had prop drilled because I couldn't get the parent component to update the balance after performing a send tx in the child component so was curious if you were seeing similar stale data issues. All good though

@BurntNerve BurntNerve merged commit b6acf26 into main Mar 20, 2024
4 checks passed
@BurntNerve BurntNerve deleted the nerve/receive branch March 20, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants