Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sig verify to demo #150

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Add sig verify to demo #150

merged 1 commit into from
Jul 22, 2024

Conversation

justinbarry
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Apr 17, 2024

🦋 Changeset detected

Latest commit: be7c890

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
demo-app Minor
@burnt-labs/abstraxion-core Patch
@burnt-labs/abstraxion Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
xion-js-abstraxion-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2024 9:35pm
xion-js-demo-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2024 9:35pm

@justinbarry justinbarry force-pushed the add-sig-verify-to-demo branch from 49205d0 to a2fa16a Compare April 17, 2024 03:06
@justinbarry justinbarry force-pushed the add-sig-verify-to-demo branch from a2fa16a to c7bacc6 Compare June 25, 2024 21:13
@justinbarry justinbarry marked this pull request as ready for review June 25, 2024 21:54
@justinbarry justinbarry force-pushed the add-sig-verify-to-demo branch from 60e7eaa to 755b081 Compare June 25, 2024 21:55
Copy link
Contributor

@BurntVal BurntVal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@BurntNerve BurntNerve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks really good! Just made a couple suggestions for condensing a few things.

apps/demo-app/pages/api/check-signature.ts Show resolved Hide resolved
apps/demo-app/pages/api/check-signature.ts Show resolved Hide resolved
apps/demo-app/pages/api/check-signature.ts Show resolved Hide resolved
apps/demo-app/pages/api/check-signature.ts Show resolved Hide resolved
* Add return type to getAccounts method
* Update test for SignArbSecp256k1HdWallet with new import and signature verification
* Add signature and grant verification in API
* Add example of how to verify signature in demo
@justinbarry justinbarry force-pushed the add-sig-verify-to-demo branch from 57e1311 to be7c890 Compare July 22, 2024 21:35
@justinbarry justinbarry enabled auto-merge (squash) July 22, 2024 21:35
@justinbarry justinbarry merged commit 2df184a into main Jul 22, 2024
2 of 3 checks passed
@justinbarry justinbarry deleted the add-sig-verify-to-demo branch July 22, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants